-
Notifications
You must be signed in to change notification settings - Fork 44
feat: block selection policy #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+148
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ferranbt
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #133 and contains a slightly alternative approach to #134
This PR introduces support for a block selection policy that determines whether to return the builder block or the default L2 execution client block when both are available.
The initial policy implemented compares the gas used in the builder and L2 blocks. If the builder block uses less than 10% of the gas used by the L2 block, the L2 block is selected instead. This ensures that empty or severely underfilled builder blocks are not propagated to the network.
While this threshold could be made configurable, it is fixed at 10% for now to avoid edge cases. For example, it is possible that a user submits a high fee transaction that consumes the entire block gas limit and the builder does not include the transaction (e.g. due to a custom ordering policy). If the threshold is set higher (e.g. 50%) and the builder's local mempool only has enough transactions to meet the gas target, the resulting block may appear ~50% less utilized than the default client’s block. This could enable malicious actors to delay or censor transactions from builder blocks.
To mitigate this, the gas used threshold is fixed at a conservative 10% which ensures that empty or severely underfilled builder blocks are not propagated to the network without introducing potential attack vectors to censor user txs.
This PR also moves Payload related types into a new a new module to reduce moving parts in
server.rs
.